Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump wollok version + fix filename validation error #161

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

ivojawer
Copy link
Contributor

@ivojawer ivojawer commented Jun 6, 2024

Bumpea la version de wollok y fixea algunos errores que surgieron la validacion de caracteres especiales en los archivos.

Esta skippeando las validations (polemico) pero esto se podria revertir si aceptamos los guiones (uqbar-project/wollok-ts#247 😉) o cambiamos los nombres de todos los archivos/carpetas de los ejemplos

@ivojawer ivojawer requested review from PalumboN and fdodino June 6, 2024 00:36
@fdodino
Copy link
Contributor

fdodino commented Jun 6, 2024

Bumpea la version de wollok y fixea algunos errores que surgieron la validacion de caracteres especiales en los archivos.

Esta skippeando las validations (polemico) pero esto se podria revertir si aceptamos los guiones (uqbar-project/wollok-ts#247 😉) o cambiamos los nombres de todos los archivos/carpetas de los ejemplos

jajaja, me compraste con la preventa del PR...

Copy link
Contributor

@fdodino fdodino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾 🇬🇷 👍🏼

@PalumboN PalumboN merged commit 284bf5d into master Jun 6, 2024
1 check passed
@PalumboN PalumboN deleted the bump-wollok branch June 6, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants