Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run command enhancements #116

Merged
merged 24 commits into from
Nov 28, 2023
Merged

Run command enhancements #116

merged 24 commits into from
Nov 28, 2023

Conversation

fdodino
Copy link
Contributor

@fdodino fdodino commented Nov 21, 2023

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (d49aa05) 91.28% compared to head (83517b9) 84.68%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/commands/run.ts 73.43% 34 Missing ⚠️
src/utils.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   91.28%   84.68%   -6.60%     
==========================================
  Files           5        7       +2     
  Lines         459      653     +194     
  Branches      107      158      +51     
==========================================
+ Hits          419      553     +134     
- Misses         40      100      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fdodino fdodino marked this pull request as ready for review November 26, 2023 12:29
@fdodino
Copy link
Contributor Author

fdodino commented Nov 26, 2023

@PalumboN @ivojawer listo el pollo! El fail es porque codecov es muy celoso con el % de cobertura, pero más del 72% al que llegué no creo que valga la pena el esfuerzo. Revisé bastante los programas y los games, pero me vendría bien en alguna juntada que hagamos la prueba de jugar algunas cosas heavies.

Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🌃

src/commands/run.ts Show resolved Hide resolved
test/run.test.ts Show resolved Hide resolved
@fdodino fdodino merged commit 357cb4d into master Nov 28, 2023
1 of 3 checks passed
@fdodino fdodino deleted the run-command-enhancements branch November 28, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants