Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Update Go version matrix in build workflow #1124

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

Aoang
Copy link
Contributor

@Aoang Aoang commented Feb 13, 2025

Update the Go version matrix in the build workflow to include Go 1.24. This ensures that the project is tested against the latest supported Go versions.

Update the Go version matrix in the build workflow to include
Go 1.24.x and remove Go 1.22.x. This ensures that the project
is tested against the latest supported Go versions.
@Aoang Aoang force-pushed the chore/ci-go-version branch from f1a4dc7 to 472a684 Compare February 13, 2025 13:24
@j2gg0s
Copy link
Collaborator

j2gg0s commented Feb 14, 2025

Although the Go team officially supports only the latest two versions,
I feel that the most widely used version is <= v1.22.

So, let’s support the latest three versions instead, especially right after the release of v1.24.

@Tiscs
Copy link
Collaborator

Tiscs commented Feb 14, 2025

I also think that support for go 1.22 should be retained.

@Aoang
Copy link
Contributor Author

Aoang commented Feb 14, 2025

Thanks to the compatibility of Go, the impact of updating Go versions on Bun is minimal.

bun/go.mod

Line 3 in 605cd57

go 1.22.0

The last supported version should be determined by the version specified in ⁠go.mod. Here, the change is simply that CI testing is no longer performed on this version.

Whether running tests on three versions will slow down and bulky the Pull Request process. If this isn't a concern, please reply.

@j2gg0s
Copy link
Collaborator

j2gg0s commented Feb 14, 2025

If the minimum supported version is v1.22, I believe keeping it in the CI is a good idea.
Although Go version updates introduce almost zero incompatibility issues,

Intuitively, CI runs in parallel, so adding v1.24 would consume negligible resources and wouldn’t increase our waiting time.

@j2gg0s j2gg0s merged commit fc6a894 into uptrace:master Feb 16, 2025
5 checks passed
@Aoang Aoang deleted the chore/ci-go-version branch February 17, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants