Revert "Manually fetch the submodules in github CI." #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a9595b. That commit was just a workaround because nothing else seemed to work. Now that it's merged to master and everything looks fine, let's try to remove this again and get back to "normal". Signed-off-by: Patti Vacek <[email protected]>
|
Haha, that's a nope. Closing. I guess this is necessary for the foreseeable future now? Maybe we can try again in some months. Not sure why github's own logic is so broken. |
|
:( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8a9595b (from #73).
That commit was just a workaround because nothing else seemed to work. Now that it's merged to master and everything looks fine, let's try to remove this again and get back to "normal".