secure_uploads settings for Django #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsedykh
requested changes
Oct 27, 2023
dmitry-mukhin
requested changes
Nov 10, 2023
|
just get rid of it
…On Fri, Nov 10, 2023, 20:02 Evgeniy Kirov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/django-widget.rst
<#266 (comment)>
:
> }
+If you have signed uploads enabled in your Uploadcare project, widget-based uploads will fail unless you enable the ``signed_uploads`` setting in your Django project.
+
+Note that in this case, the benefits of signed uploads are essentially negated for user uploads. So enabling this feature is only feasible if, for example, files are only uploaded via the admin interface.
Ok, need to rephrase it. At the moment I have no idea how exactly.
—
Reply to this email directly, view it on GitHub
<#266 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHB47M6XRGMU5P5L5UXJHDYDZ23XAVCNFSM6AAAAAA6TMYVIWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMRVGQYTSMRSGQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
rsedykh
requested changes
Nov 10, 2023
Co-authored-by: Roman Sedykh <[email protected]>
rsedykh
approved these changes
Nov 10, 2023
dmitry-mukhin
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #262
Enabling
secure_uploadswill expose signatures to allFileFields, not only limited to Django admin. While this may be desired in some cases, it also poses a security risk for websites with user uploads. This has been highlighted in the documentation, but it may need to be rephrased somehow (@rsedykh?).