Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/activity-tracking: pass extra when logging events #13

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

phndiaye
Copy link
Member

@phndiaye phndiaye commented Apr 3, 2024

What does this PR do?

services/activity-tracking: pass extra when logging events

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Properly labeled

@phndiaye phndiaye requested review from Miexil, JulienVannier66 and a team as code owners April 3, 2024 06:47
@phndiaye phndiaye requested review from aprentout and removed request for a team April 3, 2024 06:47
Copy link

linear bot commented Apr 3, 2024

@phndiaye phndiaye merged commit 922adc8 into main Apr 3, 2024
3 checks passed
@phndiaye phndiaye deleted the pn/vel-2658 branch April 3, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants