Fix #14 Tests fail with spring-web:5.2.3 and hateoas:1.0.3 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello? :) |
|
Hey Réda, Firstly thanks again for contributing. My apologies for the delay. This feels like a major version since we'll be breaking it for people not up to date on dependencies. I'm thinking this goes into 3.0.0 and we release straight away, since there are no other changes queued. Are you happy with that approach? |
|
Hey, |
|
Do you expect me to bump the version in this PR? |
|
No thanks, I'll sort that as part of the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is not backward compatible with Spring HATEOAS 1.0.2 and earlier.