fix: ios navbar lifecycle #1331
Open
+156
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1331.eastus2.azurestaticapps.net |
kazo0
reviewed
Feb 3, 2025
Comment on lines
+20
to
+27
| <AppBarButton Click="NavigateBack" | ||
| Label="Close" | ||
| AutomationProperties.AutomationId="FluentPage2NavBarMainCommand" | ||
| Style="{StaticResource DefaultAppBarButtonStyle}"> | ||
| <AppBarButton.Icon> | ||
| <BitmapIcon UriSource="ms-appx:///Assets/CloseIcon.png" /> | ||
| </AppBarButton.Icon> | ||
| </AppBarButton> |
There was a problem hiding this comment.
I'm curious about the need to add an AppBarButton here. We should be automatically displaying a default (native on mobile) button with the default Back arrow icon if no MainCommand is explicitly defined.
Was this just to facilitate the UI Tests to know what to tap? We should test both cases, one with a MainCommand defined, and one with no MainCommand defined. They should both be working the same way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes https://github.com/unoplatform/uno.chefs/issues/1392
PR Type
What kind of change does this PR introduce?
What is the current behavior?
iOS NavigationBar lifecycle wasn't handled correctly since on iOS the NavBar is always UnLoaded by default when navigating away.
What is the new behavior?
Added OnLoaded for both iOS and Android
NavigationBarPresenterPR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):