Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the logic of the input that takes the address to which the cryptocurrency is to be sent #86

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update the logic of the input that takes the address to which the cryptocurrency is to be sent #86

wants to merge 4 commits into from

Conversation

francocarballar
Copy link
Collaborator

@francocarballar francocarballar commented Jul 27, 2023 •
edited
Loading

Changes Made

  • feat: added new feature to improve user experience
  • fix: fixed a bug with wallet address input
  • refactor: improved code readability and organization
  • docs: updated README with new instructions
  • chore: updated configuration files

Describe Changes

Related Issue(s)

none

Visuals (Optional)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@vercel
Copy link

vercel bot commented Jul 27, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @jonallamas on Vercel.

@jonallamas first needs to authorize it.

@francocarballar francocarballar requested a review from unllamas July 27, 2023 18:40
@francocarballar francocarballar added bug Something isn't working design labels Jul 27, 2023
unllamas
unllamas reviewed Jul 28, 2023
View reviewed changes
Copy link
Owner

@unllamas unllamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deje un par de comentarios para modificar, pero en general esta perfecto!

src/components/FullModal/Send/index.tsx Show resolved Hide resolved
src/components/FullModal/Send/index.tsx Outdated Show resolved Hide resolved
src/components/InputWithButton/index.jsx Outdated Show resolved Hide resolved
src/components/InputWithButton/index.jsx Outdated Show resolved Hide resolved
src/components/InputWithButton/index.jsx Outdated Show resolved Hide resolved
src/components/InputWithButton/index.jsx Outdated Show resolved Hide resolved
@unllamas unllamas self-requested a review July 29, 2023 21:56
unllamas
unllamas approved these changes Jul 29, 2023
View reviewed changes
Copy link
Owner

@unllamas unllamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impecable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unllamas unllamas unllamas approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocarballar @unllamas