Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add supabase-storage driver #403

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

PikiLee
Copy link
Contributor

@PikiLee PikiLee commented Mar 4, 2024

πŸ”— Linked issue

#397

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds a Supabase Storage driver utilizing the β€œ@supabase/supabase-js” package. Additionally, it mocks the storage-related methods of the SupabaseClient for unit tests.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

This comment was marked as off-topic.

@pi0 pi0 changed the title feat: add supabase storage driver feat: add supabase-storage driver May 1, 2024
@pi0 pi0 added the driver label May 1, 2024
@pi0
Copy link
Member

pi0 commented Dec 18, 2024

Thanks again for the PR and sorry it got stuck.

unstorage has a lightweight s3 driver now and supabase storage supports S3 compatible API (in alpha). (there is a compatibility issue for now).

I'm thinking it would be better if we unify on s3 API instead of depending on @supabase/storage-js because it needs more long term maintenance and user dependencies.

I will try to find better contact with supabase team to see how it goes.

@pi0 pi0 marked this pull request as draft December 18, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants