Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change interpreter calling conventions to be more direct #5542

Merged
merged 9 commits into from
Jan 15, 2025
+1,185 −1,476
Merged

Change interpreter calling conventions to be more direct #5542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c7c955c
Change ForeignConvention structure
dolio Jan 9, 2025
0bcd44d
Merge remote-tracking branch 'origin/trunk' into topic/calling-conven…
dolio Jan 10, 2025
cc200c9
Add defined tags for Exception
dolio Jan 14, 2025
9472d1f
Modify foreign declarations and machine implementation for new conven…
dolio Jan 14, 2025
e397f80
Fix tuple conventions, and make them more concise
dolio Jan 14, 2025
4939b99
Fix calling convention of safe array freezes
dolio Jan 14, 2025
c95c31a
Fix various calling convention problems
dolio Jan 14, 2025
b649776
Merge remote-tracking branch 'origin/trunk' into topic/calling-conven…
dolio Jan 14, 2025
85feecc
Delete some dead, commented code
dolio Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions parser-typechecker/src/Unison/Builtin/Decls.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ constructorId ref name = do
(_, _, dd) <- find (\(_, r, _) -> Reference.DerivedId r == ref) builtinDataDecls
fmap fromIntegral . elemIndex name $ DD.constructorNames dd

effectId :: Reference -> Text -> Maybe ConstructorId
effectId ref name = do
(_, _, ed) <- find (\(_, r, _) -> Reference.DerivedId r == ref) builtinEffectDecls
fmap fromIntegral . elemIndex name . DD.constructorNames $ DD.toDataDecl ed

noneId, someId, okConstructorId, failConstructorId, docBlobId, docLinkId, docSignatureId, docSourceId, docEvaluateId, docJoinId, linkTermId, linkTypeId, eitherRightId, eitherLeftId :: ConstructorId
isPropagatedConstructorId, isTestConstructorId, bufferModeNoBufferingId, bufferModeLineBufferingId, bufferModeBlockBufferingId, bufferModeSizedBlockBufferingId :: ConstructorId
seqViewEmpty, seqViewElem :: ConstructorId
Expand Down Expand Up @@ -153,6 +158,25 @@ bufferModeBlockBufferingId = Maybe.fromJust $ constructorId bufferModeRef "io2.B

bufferModeSizedBlockBufferingId = Maybe.fromJust $ constructorId bufferModeRef "io2.BufferMode.SizedBlockBuffering"

fileModeReadId, fileModeWriteId, fileModeAppendId, fileModeReadWriteId :: ConstructorId
fileModeReadId = Maybe.fromJust $ constructorId fileModeRef "io2.FileMode.Read"
fileModeWriteId = Maybe.fromJust $ constructorId fileModeRef "io2.FileMode.Write"
fileModeAppendId = Maybe.fromJust $ constructorId fileModeRef "io2.FileMode.Append"
fileModeReadWriteId = Maybe.fromJust $ constructorId fileModeRef "io2.FileMode.ReadWrite"

seekModeAbsoluteId, seekModeRelativeId, seekModeEndId :: ConstructorId
seekModeAbsoluteId = Maybe.fromJust $ constructorId seekModeRef "io2.SeekMode.AbsoluteSeek"
seekModeRelativeId = Maybe.fromJust $ constructorId seekModeRef "io2.SeekMode.RelativeSeek"
seekModeEndId = Maybe.fromJust $ constructorId seekModeRef "io2.SeekMode.SeekFromEnd"

stdInId, stdOutId, stdErrId :: ConstructorId
stdInId = Maybe.fromJust $ constructorId stdHandleRef "io2.StdHandle.StdIn"
stdOutId = Maybe.fromJust $ constructorId stdHandleRef "io2.StdHandle.StdOut"
stdErrId = Maybe.fromJust $ constructorId stdHandleRef "io2.StdHandle.StdErr"

exceptionRaiseId :: ConstructorId
exceptionRaiseId = Maybe.fromJust $ effectId exceptionRef "Exception.raise"

okConstructorReferent, failConstructorReferent :: Referent.Referent
okConstructorReferent = Referent.Con (ConstructorReference testResultRef okConstructorId) CT.Data
failConstructorReferent = Referent.Con (ConstructorReference testResultRef failConstructorId) CT.Data
Expand Down
Loading
Loading