Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rendering for textbox and hyperlink #119

Merged
merged 4 commits into from
Nov 19, 2023
Merged

feat: add rendering for textbox and hyperlink #119

merged 4 commits into from
Nov 19, 2023

Conversation

mhatzl
Copy link
Contributor

@mhatzl mhatzl commented Nov 19, 2023

This PR adds rendering for TextBox and Hyperlink.
Math rendering is added, but output is plain text for now.

This PR also includes some fixes for ambiguous inline tokens and textbox parsing.
It also adds spec tests for inlines
(could have been added with another PR, but I had to fix textbox parsing anyways for this PR).

Relevant decisions you made in this PR

Math rendering outputs plain content for now,
because rendering of math expressions is not yet implemented.

Copy link
Collaborator

@nfejzic nfejzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

parser/src/parser.rs Show resolved Hide resolved
@mhatzl mhatzl merged commit 10bbdf0 into main Nov 19, 2023
3 checks passed
@mhatzl mhatzl deleted the render-update branch November 19, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants