Renamed potentially confusing variables #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @maanikmarathe, @behinger, and I discussed, that some variable names in
simulation.jlare a bit confusing, I renamed them:signalthat were referring to a<:AbstractComponentI renamed tocomponentsorcomponent.add_responses!function, I renamederpvectotrial_idx.@maanikmarathe, do you think it's clearer now or is there still something missing?
@behinger, could you quickly check that I did not make any stupid mistakes during the renaming which breaks the code? Is naming it
componentsokay or would you rather name itcomponent? I thought of a vector of components therefore I named it components.