feat: title prefix for different environments #1011 #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a prefix to the browser tab title based on the current configured deployment env. **Changes**: - The environment callback can now return a dict with the `label`, `color_accent` and `title_prefix` keys. - This change is backward compatible with the current return value as a list of 2 items. - Added `get_environment_context` to the `UnfoldAdminSite` class that's is called in the `each_context` method to achieve the above changes. - Adjusted the templates and tests to reflect these changes.
for more information, see https://pre-commit.ci
|
This requires manual testing of the UI which I'm still trying to figure out as I'm facing issues with my devcontainers setup. |
|
@lukasvinclav attached screenshot of the changes in the PR description, looking forward to your feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a prefix to the browser tab title based on the current configured deployment env, this resolves issue #1011
Changes:
label,color_accentandtitle_prefixkeys.get_environment_contextto theUnfoldAdminSiteclass that's is called in theeach_contextmethod to achieve the above changes.Screenshots:
