Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNDERTOW-2279 investigation #1488

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

fl4via
Copy link
Member

@fl4via fl4via commented Jun 7, 2023

No description provided.

fl4via added 5 commits June 7, 2023 00:55
…and clear the allocated buffer to prevent NPEs when ClosedChannelExceptions and broken pipe SocketExceptions occur.

Those NPEs can occur at the points where the buffer is closed and it is already null because the buffer was cleared by an inner recursive call as an attempt to deal with the exception.
The broken pipe can occur when a browser tab is closed during the response writing process.

Signed-off-by: Flavia Rainone <[email protected]>
…reset expireTime to -1, disabling future checks for write timeout at timeoutCommand runnable

Signed-off-by: Flavia Rainone <[email protected]>
…ore closing the connection to give a chance to outer channels wrap up. At ChunkedStreamSinkConduit create the last chunk and attempt to flush before truncating writes.

Signed-off-by: Flavia Rainone <[email protected]>
…ring and, instead, just fail the test if there is no header

Signed-off-by: Flavia Rainone <[email protected]>
@fl4via fl4via added under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check labels Jun 7, 2023
@fl4via fl4via force-pushed the UNDERTOW-2279_INVESTIGATION branch 2 times, most recently from e318766 to 6ab7862 Compare June 7, 2023 15:15
… failed on unrelated PR CIs we know it is a preexisting intermitent failure

Signed-off-by: Flavia Rainone <[email protected]>
@fl4via fl4via force-pushed the UNDERTOW-2279_INVESTIGATION branch from 6ab7862 to b2958ef Compare June 7, 2023 15:17
Signed-off-by: Flavia Rainone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant