GitHub pagify #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These links referenced now non-existent cgit and dashboard pages.
also adds a layout to not show the title/navbar on slides.
Some links that end with .md automatically get changed to .html links, while others don't. Removing the file extension altogether seems too help with consistency.
|
Also there's a couple of dead cgit links in some of the assignments that link to what would be example/starter code. I don't know if we should delete those links or have them link somewhere else. |
Signed-off-by: Joel Savitz <[email protected]>
michael-burke4
force-pushed
the
github-pagify
branch
from
dfd23de to
6bcaa27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking this as a draft as theres a couple concerns I want some input on before I PR for real:
Right now I've just pasted all of the 'articles' from the kernel stash into the _articles directory, it'd probably be better to add a dedicated articles repo as a submodule. Also, if these aren't meant to be public yet I can remove them!
I ran into an annoying issue where relative links to .md pages within the website sometimes wouldn't get properly translated into .html links. As in: by default jekyll (or a jekyll plugin that is on by default in gh pages) automatically translates any links to .md pages within the same website to .html. So if a .md doc like "/course/fall2023/index.md" has a link to "/course/fall2023/L1.md", jekyll would automatically translate that L1.md link to L1.html. Some of these links would not get translated, so instead of showing a nicely rendered html page, the links would bring you to a raw plain text view in your browser. As a band-aid I removed the .md extension from any links, so that L1 link for example would read "/course/fall2023/L1". This solution works, and changing all .md links to .html manually would work, but both are inelegant and confusing when making the website. I'll take a stab at making .md links work again, but if the no extension/manual .html is fine then we could stick with that.