Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No links table #1310

Merged
merged 4 commits into from
Nov 29, 2020
Merged

No links table #1310

merged 4 commits into from
Nov 29, 2020

Conversation

tcnh
Copy link
Contributor

@tcnh tcnh commented Nov 20, 2020

Support a Table type (prefix ^) that doesn't parse wikiwords, links and emailadresses.

Extended version of #1307, implementing the 'requirement' from #1308

@fhoeben
Copy link
Collaborator

fhoeben commented Nov 20, 2020

Looks pretty good. We should probably add an acceptance test for the noLinks table.

Maybe we can prevent having to call pluginsLoader.loadSymbolTypes() twice (for each provider) by making the copy at a later point in time (i.e. after the plugins are loaded)? But on the other hand this approach allows a plugin to choose whether a symbol should be included in both providers, or only in one...

@tcnh
Copy link
Contributor Author

tcnh commented Nov 23, 2020

What would a logical place for such an acceptance test be? I see no acceptance test for i.e. a literal table.

We could indeed copy at a later point to prevent the double administration, but I can imagine situations where one would want to exclude a custom symboltype from this table. I'd alway opt for more extensibility if the cost is not too high.

@jediwhale
Copy link
Collaborator

See FitNesse.SuiteAcceptanceTests.SuiteWidgetTests.TestTables - could add to this or make a new FitNesse.SuiteAcceptanceTests.SuiteWidgetTests.TestTablesNoLink

@tcnh
Copy link
Contributor Author

tcnh commented Nov 25, 2020

Thanks! Added an acceptance test to that page

@fhoeben fhoeben merged commit d21d53a into unclebob:master Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants