Reorganise admin navigation and add requirements #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeltrix
force-pushed
the
reorganise-admin
branch
5 times, most recently
from
caa0e1a to
62c1aec
Compare
This is to ensure that any future addition of this component to govuk-frontend will not clash with our implementation.
This makes it easier to keep it updated.
This hopefully makes it easier to migrate to an official component in the future.
pixeltrix
force-pushed
the
reorganise-admin
branch
from
62c1aec to
8bdfc36
Compare
The inspect output for hashes changed in Ruby 3.4 to use the 1.9 syntax where possible and to pad the hash rockets with spaces when not possible.
pixeltrix
force-pushed
the
reorganise-admin
branch
from
8bdfc36 to
01f3726
Compare
pixeltrix
changed the title
benbaumann95
approved these changes
Feb 4, 2025
| @@ -35,7 +35,7 @@ def search_query | |||
|
|
|||
| def search_param(query) | |||
| query.to_s | |||
| .scan(/[-\w]{1,}/) | |||
| .scan(/[-\w]{2,}/) | |||
There was a problem hiding this comment.
Doesn't this require at least two characters, not just one?
There was a problem hiding this comment.
No, it's one character for the - and then one for a letter. Without this change the query is !:* for Floor plans - existing which is invalid and raises an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Story Link
https://trello.com/c/Ohgw2fkH
Screenshots
Todo