Move routing constraints to BopsCore engine

This is so they can be reused in other engines.

config/application.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require_relative "boot"
-require_relative "../lib/constraints/subdomain"
 
 require "rails"
 # Pick the frameworks you want:

config/routes.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
 
 Rails.application.routes.draw do
+  extend BopsCore::Routing
+
   get :healthcheck, to: proc { [200, {}, %w[OK]] }
 
-  constraints Constraints::DeviseSubdomain do
+  devise_subdomain do
     devise_for :users, controllers: {
       sessions: "users/sessions",
       confirmations: "confirmations"
@@ -16,7 +18,7 @@
     end
   end
 
-  constraints Constraints::LocalAuthoritySubdomain do
+  local_authority_subdomain do
     root to: "planning_applications#index"
 
     concern :positionable do |options|
@@ -382,11 +384,9 @@
     end
   end
 
-  constraints Constraints::ConfigSubdomain do
+  config_subdomain do
     mount BopsConfig::Engine, at: "/", as: :bops_config
   end
 
-  constraints Constraints::UploadsSubdomain do
-    mount BopsUploads::Engine, at: "/", as: :bops_uploads
-  end
+  mount BopsUploads::Engine, at: "/", as: :bops_uploads
 end

engines/bops_core/lib/bops_core.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "bops_core/engine"
+require "bops_core/routing"
 
 module BopsCore
   class << self

engines/bops_core/lib/bops_core/routing.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+module BopsCore
+  module Routing
+    extend ActiveSupport::Concern
+
+    class LocalAuthoritySubdomain
+      class << self
+        def matches?(request)
+          LocalAuthority.pluck(:subdomain).include?(request.subdomain)
+        end
+      end
+    end
+
+    class ConfigSubdomain
+      class << self
+        def matches?(request)
+          request.subdomain == "config"
+        end
+      end
+    end
+
+    class DeviseSubdomain
+      class << self
+        def matches?(request)
+          ConfigSubdomain.matches?(request) || LocalAuthoritySubdomain.matches?(request)
+        end
+      end
+    end
+
+    class UploadsSubdomain
+      class << self
+        def matches?(request)
+          request.subdomain == "uploads"
+        end
+      end
+    end
+
+    def local_authority_subdomain(&)
+      constraints(LocalAuthoritySubdomain, &)
+    end
+
+    def config_subdomain(&)
+      constraints(ConfigSubdomain, &)
+    end
+
+    def devise_subdomain(&)
+      constraints(DeviseSubdomain, &)
+    end
+
+    def uploads_subdomain(&)
+      constraints(UploadsSubdomain, &)
+    end
+  end
+end

engines/bops_uploads/config/routes.rb

@@ -1,7 +1,11 @@
 # frozen_string_literal: true
 
 BopsUploads::Engine.routes.draw do
-  get "/:key", to: "files#show", as: "file"
+  extend BopsCore::Routing
+
+  uploads_subdomain do
+    get "/:key", to: "files#show", as: "file"
+  end
 end
 
 Rails.application.routes.draw do