Skip to content

Commit

Permalink
Change wording to Check application details
Browse files Browse the repository at this point in the history
  • Loading branch information
EGiataganas committed Jan 23, 2025
1 parent a517d35 commit 1d05421
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 28 deletions.
4 changes: 2 additions & 2 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1239,7 +1239,7 @@ en:
edit_check_description: Edit check description, documents and proposal
introduction:
application_details: Application details
check_description_documents: Check description, documents, and proposal details
check_description_documents: Check application details
checking_plans_and: Checking plans and description
review_the_items: Review the description, site map, and documents submitted by the applicant to check they are consistent.
proposal_details_match_documents:
Expand Down Expand Up @@ -1408,7 +1408,7 @@ en:
check_consistency:
check_application: Check application
complete: Complete
description_documents_and: Check description, documents and proposal details
description_documents_and: Check application details
in_assessment: In assessment
permitted_development_rights: Permitted development rights
index:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
within(".app-task-list") do
within("#check-consistency-assessment-tasks") do
expect(page).to have_content("Check application")
expect(page).to have_link("Check description, documents and proposal details")
expect(page).to have_link("Check application details")
expect(page).to have_link("Permitted development rights")

expect(page).not_to have_link("Evidence of immunity")
Expand Down Expand Up @@ -66,7 +66,7 @@
within(".app-task-list") do
within("#check-consistency-assessment-tasks") do
expect(page).to have_content("Check application")
expect(page).to have_link("Check description, documents and proposal details")
expect(page).to have_link("Check application details")
expect(page).to have_link("Permitted development rights")

expect(page).not_to have_link("Evidence of immunity")
Expand Down Expand Up @@ -224,7 +224,7 @@
within(".app-task-list") do
within("#check-consistency-assessment-tasks") do
expect(page).to have_content("Check application")
expect(page).to have_link("Check description, documents and proposal details")
expect(page).to have_link("Check application details")
expect(page).to have_link("Evidence of immunity")
expect(page).to have_link("Immunity/permitted development rights")
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
it "lets user save draft or mark as complete" do
expect(list_item("Check and assess")).to have_content("Not started")
click_link("Check and assess")
click_link("Check description, documents and proposal details")
click_link("Check application details")
click_button("Save and mark as complete")

expect(page).to have_content(
Expand Down Expand Up @@ -69,7 +69,7 @@

expect(task_list_item).to have_content("In progress")

click_link("Check description, documents and proposal details")
click_link("Check application details")

form_group4 = form_group_with_legend(
"Are the proposal details consistent with the plans?"
Expand All @@ -88,7 +88,7 @@

expect(task_list_item).to have_content("Completed")

click_link("Check description, documents and proposal details")
click_link("Check application details")

field1 = find_by_id(
"consistency-checklist-description-matches-documents-yes-field"
Expand Down Expand Up @@ -138,7 +138,7 @@
it "lets user save draft or mark as complete" do
expect(list_item("Check and assess")).to have_content("Not started")
click_link("Check and assess")
click_link("Check description, documents and proposal details")
click_link("Check application details")
click_button("Save and mark as complete")

expect(page).to have_content(
Expand Down Expand Up @@ -176,7 +176,7 @@

expect(task_list_item).to have_content("In progress")

click_link("Check description, documents and proposal details")
click_link("Check application details")

form_group4 = form_group_with_legend(
"Are the proposal details consistent with the plans?"
Expand Down Expand Up @@ -206,7 +206,7 @@

expect(task_list_item).to have_content("Completed")

click_link("Check description, documents and proposal details")
click_link("Check application details")

field1 = find_by_id(
"consistency-checklist-description-matches-documents-yes-field"
Expand Down Expand Up @@ -263,7 +263,7 @@
it "when site map is correct" do
expect(list_item("Check and assess")).to have_content("Not started")
click_link("Check and assess")
click_link("Check description, documents and proposal details")
click_link("Check application details")
click_button("Save and mark as complete")

expect(page).to have_content(
Expand Down Expand Up @@ -301,7 +301,7 @@

expect(task_list_item).to have_content("In progress")

click_link("Check description, documents and proposal details")
click_link("Check application details")

form_group4 = form_group_with_legend(
"Are the proposal details consistent with the plans?"
Expand All @@ -315,7 +315,7 @@

expect(task_list_item).to have_content("Completed")

click_link("Check description, documents and proposal details")
click_link("Check application details")

field1 = find_by_id(
"consistency-checklist-description-matches-documents-yes-field"
Expand Down Expand Up @@ -348,7 +348,7 @@
it "when site map is wrong leave a comment" do
expect(list_item("Check and assess")).to have_content("Not started")
click_link("Check and assess")
click_link("Check description, documents and proposal details")
click_link("Check application details")
click_button("Save and mark as complete")

expect(page).to have_content(
Expand Down Expand Up @@ -391,7 +391,7 @@

expect(task_list_item).to have_content("In progress")

click_link("Check description, documents and proposal details")
click_link("Check application details")

form_group4 = form_group_with_legend(
"Are the proposal details consistent with the plans?"
Expand All @@ -410,7 +410,7 @@

expect(task_list_item).to have_content("Completed")

click_link("Check description, documents and proposal details")
click_link("Check application details")

field1 = find_by_id(
"consistency-checklist-description-matches-documents-yes-field"
Expand Down Expand Up @@ -456,7 +456,7 @@
it "lets the user request a description change" do
travel_to(Time.zone.local(2022, 9, 15, 12))
click_link("Check and assess")
click_link("Check description, documents and proposal details")
click_link("Check application details")

form_group = form_group_with_legend(
"Does the description match the development or use in the plans?"
Expand Down Expand Up @@ -519,7 +519,7 @@
.auto_close_request!

visit "/planning_applications/#{planning_application.reference}/assessment/tasks"
click_link("Check description, documents and proposal details")
click_link("Check application details")

expect(page).to have_content("Accepted 15 September 2022 13:00")

Expand Down Expand Up @@ -561,7 +561,7 @@
request.close!
request.update!(approved: true)
visit "/planning_applications/#{planning_application.reference}/assessment/tasks"
click_link("Check description, documents and proposal details")
click_link("Check application details")

expect(page).to have_content("Accepted 15 September 2022 14:00")
expect(page).to have_link("Request a change to the description")
Expand All @@ -576,7 +576,7 @@
it "lets the user request an additional document" do
travel_to(Time.zone.local(2022, 9, 15, 12))
click_link("Check and assess")
click_link("Check description, documents and proposal details")
click_link("Check application details")

form_group = form_group_with_legend(
"Are the plans consistent with each other?"
Expand Down Expand Up @@ -618,7 +618,7 @@

click_button("Confirm cancellation")
visit "/planning_applications/#{planning_application.reference}/assessment/tasks"
click_link("Check description, documents and proposal details")
click_link("Check application details")

expect(page).to have_content("Cancelled 15 September 2022 12:00")

Expand All @@ -640,7 +640,7 @@

it "lets the user navigate to the document" do
click_link("Check and assess")
click_link("Check description, documents and proposal details")
click_link("Check application details")
click_link("View new document")
expect(page).to have_content("File name: proposed-floorplan.png")
end
Expand All @@ -649,7 +649,7 @@
it "lets the user request a red line boundary change" do
travel_to(Time.zone.local(2022, 9, 15, 12))
click_link("Check and assess")
click_link("Check description, documents and proposal details")
click_link("Check application details")

form_group = form_group_with_legend(
"Is the site map correct?"
Expand Down Expand Up @@ -692,7 +692,7 @@
"Validation request for red line boundary successfully created."
)

click_link("Check description, documents and proposal details")
click_link("Check application details")

form_group = form_group_with_legend(
"Is the site map correct?"
Expand Down Expand Up @@ -721,7 +721,7 @@
click_button("Confirm cancellation")
click_link("Application")
click_link("Check and assess")
click_link("Check description, documents and proposal details")
click_link("Check application details")

expect(page).to have_content("Cancelled 15 September 2022 12:00")

Expand All @@ -737,7 +737,7 @@ def form_group_with_legend(legend)
end

def task_list_item
text = "Check description, documents and proposal details"
text = "Check application details"
find("span", text:).find(:xpath, "..")
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"/planning_applications/#{planning_application.reference}/assessment/tasks"
)

click_link("Check description, documents and proposal details")
click_link("Check application details")
find("span", text: "Application information")
click_link("Edit details")

Expand Down

0 comments on commit 1d05421

Please sign in to comment.