Waits for terminal stack status when summarizing #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, iidy is getting an in progress state when summarizing stack contents. It's possible this is just due to timing. When we know we're going to be in a terminal state, we can just wait for a terminal status to be returned instead of accepting the in progress status. It's not clear why this specifically happens with `UPDATE_COMPLETE_CLEANUP_IN_PROGRESS`, but it could be a special case for timing.
Kazzer
force-pushed
the
x-cleanup-in-progress
branch
from
31e872b to
e4e1fe4
Compare
|
@tavisrudd Although it did resolve the immediate issue, there was some concern about considering UPDATE_COMPLETE_CLEANUP_IN_PROGRESS a final state, so we're actually going with this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, we are getting non-terminal statuses when summarizing. It's possible this is a timing issue, so we'll naïvely attempt to get the stack description again until we receive a response with a terminal status.
By the time we make this call, we already know that we'll be in a terminal status because the watcher will only stop once we've seen a terminal status. This is why the logging will always have something like:
where the last line will be
UPDATE_COMPLETE, but iidy will summarize withwhich is clearly not the status from the last line.