Simplify Whitelisted Headers #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymndhng
force-pushed
the
kaizen-improvements
branch
from
57c0426 to
709cfd1
Compare
Refactor simple-headers-wo-content-type to access-control-request-headers-whitelist. The whitelist behaves differently by `set/difference`-ing `access-control-request-headers` instead of `set/union` the `access-control-allowed-headers`. This way, we do not put unnecessary headers in the response `access-control-allowed-headers`. From testing, the only required header in the whitelist is "Origin". Safari always sends this in "Access-Control-Request-Headers" during pre-flight, whereas the Firefox and Chrome do not.
rymndhng
force-pushed
the
kaizen-improvements
branch
from
709cfd1 to
5bb23ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor simple-headers-wo-content-type to access-control-request-headers-whitelist.
The whitelist behaves differently by
set/difference-ingaccess-control-request-headersinstead ofset/uniontheaccess-control-allowed-headers. This way, we do not put unnecessaryheaders in the response
access-control-allowed-headers.From testing, the only required header in the whitelist is
"Origin". Safari always sends this in "Access-Control-Request-Headers"
during pre-flight, whereas the Firefox and Chrome do not.