fix(array): fix array handler

unadlib · Jan 12, 2025 · 6103b6a · 6103b6a
1 parent a19b152
commit 6103b6a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/src/draft.ts b/src/draft.ts
@@ -38,7 +38,7 @@ const draftsCache = new WeakSet<object>();
 
 let arrayHandling = false;
 
-const proxyArrayMethods = ['splice', 'shift', 'unshift'];
+const proxyArrayMethods = ['splice', 'shift', 'unshift', 'reverse', 'sort'];
 
 const proxyHandler: ProxyHandler<ProxyDraft> = {
   get(target: ProxyDraft, key: string | number | symbol, receiver: any) {
@@ -116,10 +116,7 @@ const proxyHandler: ProxyHandler<ProxyDraft> = {
           arrayHandling = true;
           try {
             returnValue = value.apply(this, args);
-            if (key === 'splice' && returnValue.length > 0) {
-              returnValue = returnValue.map(handleItem);
-            }
-            if (key === 'shift' && typeof returnValue === 'object') {
+            if (typeof returnValue === 'object') {
               returnValue = handleItem(returnValue);
             }
             return returnValue;

diff --git a/test/__snapshots__/apply.test.ts.snap b/test/__snapshots__/apply.test.ts.snap
@@ -4635,6 +4635,15 @@ exports[`array - update 22`] = `
 
 exports[`array - update 23`] = `
 [
+  {
+    "op": "replace",
+    "path": [
+      "a",
+      2,
+      "i",
+    ],
+    "value": 18,
+  },
   {
     "op": "replace",
     "path": [
@@ -4840,6 +4849,15 @@ exports[`array - update 23`] = `
 
 exports[`array - update 24`] = `
 [
+  {
+    "op": "replace",
+    "path": [
+      "a",
+      2,
+      "i",
+    ],
+    "value": 17,
+  },
   {
     "op": "replace",
     "path": [