Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use all In-Reply-To and References to find related messages #759

Merged

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Aug 31, 2024

What does this PR do?

While finding the parent convo, use all message ids found in In-Reply-To and References header to determine any matching entries

Fixes ENG-168

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BlankParticle and the rest of your teammates on Graphite Graphite

@BlankParticle BlankParticle marked this pull request as ready for review August 31, 2024 04:55
@BlankParticle BlankParticle force-pushed the blank/fix/use-all-email-references-to-infer-parent-convo branch 3 times, most recently from 89f1f3b to d29a2ca Compare August 31, 2024 05:01
@BlankParticle BlankParticle force-pushed the blank/fix/use-all-email-references-to-infer-parent-convo branch from d29a2ca to 4ab78a7 Compare August 31, 2024 12:17
Copy link
Member Author

BlankParticle commented Aug 31, 2024

Merge activity

  • Aug 31, 8:17 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 31, 8:18 AM EDT: @BlankParticle merged this pull request with Graphite.

@BlankParticle BlankParticle merged commit 427f63b into main Aug 31, 2024
4 checks passed
@BlankParticle BlankParticle deleted the blank/fix/use-all-email-references-to-infer-parent-convo branch August 31, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants