feat: update swc from 83 to 86 #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
提 pr 前最好执行下 just ready 命令。 |
最好用 github 能识别的邮箱提交。 |
|
建议 commit msg 用英文。 |
本地执行过了，我看看是啥问题 |
sorrycc
requested changes
Jan 19, 2024
crates/core/src/lib.rs
Outdated
| @@ -13,7 +13,8 @@ pub use swc_core::css::{ | |||
| pub use swc_core::ecma::transforms::{ | |||
| base as swc_ecma_transforms, module as swc_ecma_transforms_modules, | |||
| optimization as swc_ecma_transforms_optimization, proposal as swc_ecma_transforms_proposals, | |||
| react as swc_ecma_transforms_react, typescript as swc_ecma_transforms_typescript, | |||
| react as swc_ecma_transforms_react, testing as swc_ecma_transforms_testing, | |||
There was a problem hiding this comment.
swc_ecma_transforms_testing 是干啥的？好像没用到？
There was a problem hiding this comment.
swc_ecma_transforms_testing 是干啥的？好像没用到？
删掉了，原来好像有用到
crates/mako/src/transform.rs
Outdated
| @@ -83,12 +85,20 @@ fn transform_js( | |||
| // since when use this in js, it will remove all unused imports | |||
| // which is not expected as what webpack does | |||
| if is_ts { | |||
| ast.visit_mut_with(&mut strip_with_jsx( | |||
| let mut program = Program::Module(ast.clone()); | |||
There was a problem hiding this comment.
这类看下能否用 take 避免 clone。
done
stormslowly
approved these changes
Jan 19, 2024
sorrycc
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
将swc升级到86版本，主要修改点:
部分测试用例修改:
遗留用例问题:
export const bar = {
中文: "xxx"
}
转 ascii 时，不会自动加上 ""，导致有报错，所以先手动在用例上加上双引号了。