fix: 修复sass/less-loader的路径解析 #1771
Open
+435
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
- Coverage 53.03% 53.03% -0.01%
==========================================
Files 190 190
Lines 18960 18960
==========================================
- Hits 10056 10055 -1
- Misses 8904 8905 +1 ☔ View full report in Codecov by Sentry. |
PeachScript
reviewed
Feb 26, 2025
| .catch((err: any) => { | ||
| throw new Error(err.toString()); | ||
| }); | ||
| return { content: result.css, type: 'css' }; | ||
| } | ||
|
|
||
| export { render }; | ||
|
|
||
| function getResolver(compileStringAsync: any) { |
There was a problem hiding this comment.
看上去是把 sass-loader 做的事又做了一遍，不知道有没有更好的解法，比如：
- 直接依赖 sass-loader 设法复用相关逻辑
- 搞个适配层直接用 sass-loader
- ……
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1767
sass-loader中配置importers, 完善sass文件中引用的路径解析
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
just readyEdits