Skip to content

Commit

Permalink
fix: should not re-group when span changed (#1654)
Browse files Browse the repository at this point in the history
  • Loading branch information
xusd320 authored Oct 23, 2024
1 parent 9346daf commit 9172ca7
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions crates/mako/src/dev/update.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use tracing::debug;
use crate::build::BuildError;
use crate::compiler::Compiler;
use crate::generate::transform::transform_modules;
use crate::module::{Dependency, Module, ModuleId};
use crate::module::{Dependency, Module, ModuleId, ResolveType};
use crate::module_graph::ModuleGraph;
use crate::resolve::{self, clear_resolver_cache};

Expand Down Expand Up @@ -466,14 +466,15 @@ impl Diff {
return true;
}

let new_deps: HashMap<&ModuleId, &Dependency> = new_dependencies
let new_deps: HashMap<&ModuleId, &ResolveType> = new_dependencies
.iter()
.map(|(module_id, dep)| (module_id, dep))
.map(|(module_id, dep)| (module_id, &dep.resolve_type))
.collect();

let original: HashMap<&ModuleId, &Dependency> = module_graph
let original: HashMap<&ModuleId, &ResolveType> = module_graph
.get_dependencies(module_id)
.into_iter()
.map(|(module_id, dep)| (module_id, &dep.resolve_type))
.collect();

!new_deps.eq(&original)
Expand Down

0 comments on commit 9172ca7

Please sign in to comment.