Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language-files.md #6751

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Update language-files.md #6751

merged 1 commit into from
Jan 6, 2025

Conversation

lucasdegruijter
Copy link
Contributor

Description

Added a section about using parameters with Language Files & Localization

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

@sofietoft
Copy link
Contributor

Hi @lucasdegruijter !
Thanks for the PR 💪

I'll make sure we get this reviewed as soon as possible!

@sofietoft sofietoft added review/developer Use this label if an internal developer review is required review/docsteam and removed review/docsteam labels Dec 16, 2024
@HamDerAndrew
Copy link
Contributor

Hi @lucasdegruijter

I tested this out locally on a fresh Umbraco 13.5.2.
It works like you mention.

In other words:
LGTM 👍

@sofietoft
Copy link
Contributor

Thanks for the review @HamDerAndrew , and thanks again for the PR @lucasdegruijter ! 😄

Looks like we're ready to get this merged 💪

@sofietoft sofietoft merged commit 1664880 into umbraco:main Jan 6, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/umbraco-cms review/developer Use this label if an internal developer review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants