-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds UUI-Copy #985
base: v1/contrib
Are you sure you want to change the base?
Adds UUI-Copy #985
Conversation
npm run new-package
Hi there @warrenbuckley, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
I am open for discussion and feedback to improve this |
Quality Gate passedIssues Measures |
I may need some pointers or advice with the tests please @nielslyngsoe or @iOvergaard |
Description
Adds a button to trigger copying content to the clipboard, by two approaches:
value
property on uui-copy to contain the text content you want to copy to the clipboardcopy-from
property will look for HTML element with that ID and use the text contentvalue
property then assume we want to get the value of an input field such as uui-inputNote
This is heavily inspired by Shoelace.style copy button
https://github.com/shoelace-style/shoelace/blob/next/src/components/copy-button/copy-button.component.ts
Types of changes
Motivation and context
How to test?
I believe the stories should cover some scenarios
Screenshots (if appropriate)
Checklist