Refactor workspace context creation logic #17885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the specific Main Workspace Context creating extra Workspace Context Extensions, then this PR moves the logic so it happens by the initialization of the Workspace. Enabling Workspace Context Extensions to always be initialized no matter the specific Workspace API(Workspace Context) implementation.
This moves the single mode as a feature of extension-slot to a feature of the Extension Initializers. And as part of that work started implementing args object to be parsed for those. This is thought only done for the Single Mode, but could for v.16 be adopted for all args.
This fixes so any Workspace, will get extensions of type Workspace Contexts initialized.
If you initialized a Workspace Context without the use of the workspace element () then you will now need to implement a Workspace Context initialization on your own.
Here is a example of how that can be done:
new UmbExtensionsApiInitializer(api, umbExtensionsRegistry, 'workspaceContext', [api]);