Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fail-fast: false #45

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Set fail-fast: false #45

merged 1 commit into from
Jan 1, 2025

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 1, 2025

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Updated CI workflow to enhance testing resilience by enabling fail-fast: false. πŸš€

πŸ“Š Key Changes

  • Modified the CI workflow to add fail-fast: false under the strategy for the job matrix.

🎯 Purpose & Impact

  • πŸ›  Purpose: Ensures that all test environments (OS/Python combinations) are executed, even if one fails.
  • 🌟 Impact: Provides more comprehensive feedback for debugging by identifying all failing configurations at once, improving development efficiency and reliability.

Signed-off-by: Glenn Jocher <[email protected]>
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Jan 1, 2025
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/template πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/template main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

Your PR makes an excellent contribution by introducing the fail-fast: false configuration in the CI pipeline to improve test robustness across platforms and Python versions. πŸŽ‰ This thoughtful update will enhance the debugging process and ensure comprehensive test coverage. πŸš€

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! An Ultralytics engineer will review your PR soon. πŸ€–

@glenn-jocher glenn-jocher merged commit 363bbcd into main Jan 1, 2025
8 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch January 1, 2025 16:05
@UltralyticsAssistant
Copy link
Member

πŸŽ‰ Your PR has been merged, @glenn-jocher! Thank you for solidifying our CI resilience with fail-fast: false. Your attention to detail ensures every corner of our workflows gets the attention it deserves. πŸ› οΈπŸš€

As Leonardo da Vinci once said, "Details make perfection, and perfection is not a detail." Your contribution helps build a stronger, more reliable foundation for all. Thank you for your impactful workβ€”it truly makes a difference! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants