Add dynamic test for row count

uktrade · Dec 5, 2024 · 746a94e · 746a94e
1 parent 8106e89
commit 746a94e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/cypress/specs/dataset-data-preview-spec.js b/cypress/specs/dataset-data-preview-spec.js
@@ -38,14 +38,17 @@ describe("Dataset data preview page", () => {
     });
 
     it("Should display the corret number of rows", () => {
-      //   cy.get(".row-count")
-      //     .its("length")
-      //     .then((rowCount) => {
-      cy.get('p[data-testid="row-count"]').should("contain", "236 rows");
-      // });
+      cy.get('p[data-testid="row-count"]')
+        .invoke("attr", "data-row-count")
+        .then((rowCount) => {
+          cy.get('p[data-testid="row-count"]').should(
+            "contain",
+            `${rowCount} rows`
+          );
+        });
     });
 
-    it.only("Should display the table or report table", () => {
+    it("Should display the table or report table", () => {
       cy.get('table[data-testid="data-table"]').should("exist");
       cy.get(".data-preview-headers").should("exist");
       cy.get(".data-preview-body")

diff --git a/trade_data_catalogue/templates/dataset_catalogue/preview.html b/trade_data_catalogue/templates/dataset_catalogue/preview.html
@@ -189,7 +189,11 @@ <h3 class="govuk-notification-banner__heading">
       </ul>
     </nav>
   </div>
-  <p class="row-count govuk-body-s" data-testid="row-count">
+  <p
+    class="row-count govuk-body-s"
+    data-testid="row-count"
+    data-row-count="{{row_count}}"
+  >
     {{row_count}} rows
   </p>
 </div>