Revert changes which introduced celery-based elasticsearch signal processing #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincarrogan
approved these changes
May 17, 2024
saruniitr
approved these changes
May 17, 2024
delete-merged-branch
bot
deleted the
LTD-4939-revert-optimise-assessment-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b94e330, reversing changes made to 111fd8c.
Aim
It turns out there are a few problems with django-elasticsearch-dsl's celery signal processing.
https://sentry.ci.uktrade.digital/organizations/dit/issues/120926/?environment=uat&project=152&query=is%3Aunresolved - this is a bug in the library that could be fixed by this open PR; fix CelerySignalProcessor delete handling django-es/django-elasticsearch-dsl#473
https://sentry.ci.uktrade.digital/organizations/dit/issues/120927/?environment=uat&project=152&query=is%3Aunresolved
From debugging locally, it seems the following is happening:
CaseAssignment model gets saved in the web process by assigning a new caseworker. The django post_save signal fires which queues a celery task. Celery task looks up the newly created CaseAssignment record and can't find it. This is because post_save is fired before the DB transaction is committed and so the totally separate celery process won't be able to see the new record until the transaction is done.