This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Add logging and exception handling to Data Hub request functions #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverjwroberts
requested review from
cgsunkel,
marijnkampf,
p3dr0migue1,
DeanElliott96 and
bau123
as code owners
elcct
approved these changes
Jul 29, 2024
ince-dbt
approved these changes
Jul 29, 2024
oliverjwroberts
force-pushed
the
bugfix/CPS-600-add-logging-to-data-hub-requests
branch
from
e0a23d8 to
2107ace
Compare
oliverjwroberts
deleted the
bugfix/CPS-600-add-logging-to-data-hub-requests
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
To help debug ongoing (and possible future) issues between EMT and DataHub (see #986), this PR adds logging and exception handling, as well as more graceful error handling, to a couple of Data Hub request functions.
Test instructions
Upon submitting an enquiry to DataHub, if an error occurs, the server will most like return code 500 with little to no output in the logs.
Now, the application will gracefully display an error message, as well as log further information, including the response body. For this example, that would be:
{'detail': 'Incorrect authentication credentials.'}.