'toggle enquire link logs' button added

ukarim · Sep 5, 2023 · 3a94ae2 · 3a94ae2
1 parent daebf9a
commit 3a94ae2
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 4 deletions.
diff --git a/build.gradle b/build.gradle
@@ -10,7 +10,7 @@ repositories {
 
 java {
     sourceCompatibility = JavaVersion.VERSION_11
-    version = '0.1.4-SNAPSHOT'
+    version = '0.1.4'
 }
 
 def smppguiFilename = 'smppgui.jar'

diff --git a/src/main/java/com/ukarim/smppgui/core/SmppHandlerImpl.java b/src/main/java/com/ukarim/smppgui/core/SmppHandlerImpl.java
@@ -41,11 +41,17 @@ public class SmppHandlerImpl implements SmppHandler {
 
     private Charset defaultCharset;
 
+    private boolean showEnqLinkLogs = true; // show enquire_link logs by default
+
     public SmppHandlerImpl(EventDispatcher eventDispatcher) {
         this.eventDispatcher = eventDispatcher;
         this.smppClient = new SmppClient(this);
     }
 
+    public void toggleEnqLinkLogs() {
+        showEnqLinkLogs = !showEnqLinkLogs;
+    }
+
     @Override
     public Pdu handlePdu(Pdu pdu, Throwable e) {
         if (e != null) {
@@ -63,10 +69,12 @@ public Pdu handlePdu(Pdu pdu, Throwable e) {
             eventDispatcher.dispatch(EventType.SHOW_LOGIN_FORM);
             return null;
         }
-        printMsg("Pdu received:\n%s", fmtPdu(pdu));
+        if (shouldLogPdu(pdu)) {
+            printMsg("Pdu received:\n%s", fmtPdu(pdu));
+        }
 
         Pdu respPdu = handlePduInternal(pdu);
-        if (respPdu != null) {
+        if (respPdu != null && shouldLogPdu(pdu)) {
             printMsg("Pdu sent:\n%s", fmtPdu(respPdu));
         }
         return respPdu;
@@ -246,4 +254,11 @@ private String fmtPdu(Pdu pdu) {
     private String fmtPdu(Pdu pdu, Charset charset) {
         return FmtUtils.fmtPdu(pdu, charset);
     }
+
+    private boolean shouldLogPdu(Pdu pdu) {
+        if (SmppCmd.ENQUIRE_LINK.equals(pdu.getCmd())) {
+            return showEnqLinkLogs;
+        }
+        return true;
+    }
 }
diff --git a/src/main/java/com/ukarim/smppgui/gui/EventDispatcher.java b/src/main/java/com/ukarim/smppgui/gui/EventDispatcher.java
@@ -82,6 +82,10 @@ private void dispatchInternal(EventType eventType, Object eventAttach) {
             }
             case CLEAR_LOGS:
                 loggingPane.clearLogs();
+                break;
+            case TOGGLE_ENQ_LINK_LOGS:
+                smppHandler.toggleEnqLinkLogs();
+                break;
             default: {
                 // NOOP
             }

diff --git a/src/main/java/com/ukarim/smppgui/gui/EventType.java b/src/main/java/com/ukarim/smppgui/gui/EventType.java
@@ -10,4 +10,5 @@ public enum EventType {
     SHOW_INFO,
     DO_SUBMIT,
     CLEAR_LOGS,
+    TOGGLE_ENQ_LINK_LOGS,
 }
diff --git a/src/main/java/com/ukarim/smppgui/gui/MainFrame.java b/src/main/java/com/ukarim/smppgui/gui/MainFrame.java
@@ -14,7 +14,7 @@
 public class MainFrame extends JFrame {
 
     private static final int WIDTH = 1200;
-    private static final int HEIGHT = 600;
+    private static final int HEIGHT = 700;
     private static final Image ICON = Resources.loadImage("/icon.png");
     private static final String ABOUT_INFO = Resources.loadStr("/about.txt");
 

diff --git a/src/main/java/com/ukarim/smppgui/gui/SubmitForm.java b/src/main/java/com/ukarim/smppgui/gui/SubmitForm.java
@@ -12,6 +12,7 @@
 import javax.swing.JComponent;
 import javax.swing.JLabel;
 import javax.swing.JPanel;
+import javax.swing.JSeparator;
 import javax.swing.JSpinner;
 import javax.swing.JTextArea;
 import javax.swing.JTextField;
@@ -62,6 +63,9 @@ class SubmitForm extends JPanel implements ActionListener {
         var clearLogsButton = new JButton("Clear logs");
         clearLogsButton.addActionListener((e) -> eventDispatcher.dispatch(EventType.CLEAR_LOGS));
 
+        var enqLinkLogButton = new JButton("Toggle enquire links logging");
+        enqLinkLogButton.addActionListener((e) -> eventDispatcher.dispatch(EventType.TOGGLE_ENQ_LINK_LOGS));
+
         var submitButton = new JButton("Send");
         submitButton.addActionListener(this);
 
@@ -79,6 +83,8 @@ class SubmitForm extends JPanel implements ActionListener {
 
         var components = Arrays.asList(
                 new Pair(disconnectButton, clearLogsButton),
+                new Pair(null, enqLinkLogButton),
+                new Pair(new JSeparator(), new JSeparator()),
 
                 // mandatory fields
                 new Pair(new JLabel("source_addr"), srcAddrField),