Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Power balance variable rename #3417

Draft
wants to merge 87 commits into
base: main
Choose a base branch
from
Draft

Conversation

chris-ashe
Copy link
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

…total' and update references across multiple files
@chris-ashe chris-ashe requested a review from j-a-foster December 9, 2024 17:47
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 28.15789% with 273 lines in your changes missing coverage. Please review.

Project coverage is 30.31%. Comparing base (885e517) to head (1b6a843).

Files with missing lines Patch % Lines
process/power.py 30.49% 98 Missing ⚠️
process/io/sankey_funcs.py 0.00% 57 Missing ⚠️
process/stellarator.py 5.00% 38 Missing ⚠️
process/blanket_library.py 2.85% 34 Missing ⚠️
process/hcpb.py 51.42% 17 Missing ⚠️
process/dcll.py 45.00% 11 Missing ⚠️
process/physics.py 28.57% 5 Missing ⚠️
process/current_drive.py 42.85% 4 Missing ⚠️
process/io/plot_scans.py 0.00% 3 Missing ⚠️
process/ife.py 88.88% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3417      +/-   ##
==========================================
- Coverage   30.31%   30.31%   -0.01%     
==========================================
  Files          80       80              
  Lines       19534    19536       +2     
==========================================
  Hits         5922     5922              
- Misses      13612    13614       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants