🚧 3273 calculated bootstrap current fraction is overridden

[chris-ashe]

Description

A new constraint equation icc=92 and f-value fboot_max have been introduced to take over from:

 if current_drive_variables.bootipf > current_drive_variables.bscfmax:
                current_drive_variables.bootipf = min(
                    current_drive_variables.bootipf, current_drive_variables.bscfmax
                )

The above would override the calculated bootstrap current value from the model if its value ever went greater than bscfmax. Giving possible non-consistent solutions.

This may cause solutions now harder to find due to the initial conditions on the input file which can easily give bootstrap fractions greater than one and causing the injected power constraint icc=30 to crash also. Widening bounds is encouraged and the bootstrap fraction can still be directly set by setting bscfmax to the negative of the required value

The old err242 error catching variable which would output that the bootstrap current fraction limit has been enforced has now been removed from all files.

Checklist

I confirm that I have completed the following checks:

• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[stuartmuldrew]

In addition to specific comments, you should also check the functionality with cboot.

[chris-ashe]

cboot is applied to the front of each calculation before assignment. E.g:

current_drive_variables.bscf_sauter = (
            current_drive_variables.cboot * self.bootstrap_fraction_sauter()
        )

[stuartmuldrew]

Happy with the changes.