Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successfully prepare email with context but without template #468

Merged
merged 1 commit into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion post_office/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def prepare_email_message(self):
if get_override_recipients():
self.to = get_override_recipients()

if self.context is not None:
if self.template is not None and self.context is not None:
engine = get_template_engine()
subject = engine.from_string(self.template.subject).render(self.context)
plaintext_message = engine.from_string(self.template.content).render(self.context)
Expand Down
14 changes: 14 additions & 0 deletions post_office/tests/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,20 @@ def test_email_message_render(self):
self.assertEqual(message.body, 'Content test')
self.assertEqual(message.alternatives[0][0], 'HTML test')

def test_email_message_prepare_without_template_and_with_context(self):
"""
Ensure Email instance without template but with context is properly prepared.
"""
context = {'name': 'test'}
email = Email.objects.create(to=['[email protected]'], template=None,
subject='Subject test', message='Content test',
html_message='HTML test',
from_email='[email protected]', context=context)
message = email.email_message()
self.assertEqual(message.subject, 'Subject test')
self.assertEqual(message.body, 'Content test')
self.assertEqual(message.alternatives[0][0], 'HTML test')

def test_dispatch(self):
"""
Ensure that email.dispatch() actually sends out the email
Expand Down
Loading