Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor logging improvements #206

Merged
merged 1 commit into from
Feb 4, 2025
+11 −4
Merged

Minor logging improvements #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions factgenie/bin/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,9 @@ def create_llm_campaign(
@app.cli.command("run_llm_campaign")
@click.argument("campaign_id", type=str)
def run_llm_campaign(campaign_id: str):
"""
Run a LLM campaign by id.
"""
from factgenie.models import ModelFactory
from factgenie import llm_campaign
from factgenie.campaign import CampaignStatus
Expand Down
12 changes: 8 additions & 4 deletions factgenie/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import logging
from pydantic import BaseModel, Field, ValidationError
import json
import time
from ast import literal_eval
from factgenie.campaign import CampaignMode

Expand Down Expand Up @@ -180,10 +181,7 @@ def parse_annotations(self, text, annotations_json):
annotation_list = []
current_pos = 0

logger.info("Annotated text:")
logger.info(f"\033[34m{text}\033[0m")

logger.info(f"Received {len(annotations)} annotations.")
logger.info(f"Response contains {len(annotations)} annotations.")

for i, annotation in enumerate(annotations):
annotated_span = annotation.text.lower()
Expand Down Expand Up @@ -287,7 +285,13 @@ def annotate_example(self, data, text):

logger.debug(f"Prompt: {prompt}")

logger.info("Annotated text:")
logger.info(f"\033[34m{text}\033[0m")

logger.info(f"Waiting for {model_service}.")
start = time.time()
response = self.get_model_response(prompt, model_service)
logger.info(f"Received response in {time.time() - start:.2f} seconds.")

logger.debug(f"Prompt tokens: {response.usage.prompt_tokens}")
logger.debug(f"Response tokens: {response.usage.completion_tokens}")
Expand Down