Stopwords temp fix #109
Merged
Stopwords temp fix #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
100% with you re best practice there - good quick fix too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we discussed using
MiADE_CATto implement a fix for this, I feel it's not best practice to change the internals of MedCAT through our custom class and would prefer to avoid it if we can - so I think it's best to leave the stopword loading fix in a MedCAT PR CogStack/MedCAT#382This temp fix is implemented on MiADE side - it reloads the spacy model and MedCAT pipe creation, which reloads the stopwords correctly (so even if the bug gets fixed this is still backwards compatible, just an extra step at initialisation).
I'm hoping that we can use this temp fix for testing in DEV only, and just update to the latest MedCAT once the fix is implemented for TEST and PROD.