don't repetitively load jquery on staff page #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbusenius
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
This looks good to me. I'm surprised we don't have a JS block in the base page template but I guess it's never come up before. I see we conditionally load JQuery on the hours page there (different version, I'm sure). Anyhow, I don't think either of those approaches are necessary in this case. Tests are passing. I'm happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #780.
Just moves the jQuery include from the
staffapp to theunitapp so that jQuery 3.3.1 loads once.Can be previewed here:
https://wwwtrain.lib.uchicago.edu/about/directory/?view=staff