Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {redo-}hier-par-to-syn- targets to Makefile build flow #833

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

jerryz123
Copy link
Contributor

Minor QoL improvement

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix unit tests, need to add this target to the expected targets in test_hier_makefile in tests/test_build_systems.py.

If you're going to add redo-hier-par-to-syn, then might as well also add hier-par-to-syn. They both also need to be .PHONY.

@jerryz123 jerryz123 changed the title Add redo-hier-par-to-syn- target to Makefile build flow Add {redo-}hier-par-to-syn- targets to Makefile build flow Dec 15, 2023
@harrisonliew harrisonliew added this pull request to the merge queue Dec 15, 2023
Merged via the queue into master with commit e2d546c Dec 15, 2023
3 checks passed
@harrisonliew harrisonliew deleted the redo-hier-p2s branch December 15, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants