Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: un-cliwrap and use dnf5 instead of rpm-ostree #174

Merged
merged 20 commits into from
Feb 5, 2025

Conversation

inffy
Copy link
Collaborator

@inffy inffy commented Feb 3, 2025

I feel pain...

ported from https://github.com/ublue-os/bluefin/pull/2143/commits

If you could test and look this over. I will test on a VM now.

bsherman and others added 10 commits February 3, 2025 23:11
I've been tinkering with and testing dnf5 for a while.

Key items are:
- ensuring cliwrap is properly unwound (checked rpm-ostree Rust code)
- using normal (not wrapped) binaries, eg for dracut
- and the more obvious, replacing "rpm-ostree install" with "dnf5
  install", etc

Relates: #1946
the nvidia script from hwe repo had been missed before
the logo swap is new
@inffy inffy requested review from ledif, NiHaiden and RealVishy February 3, 2025 21:28
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 3, 2025
@inffy inffy marked this pull request as draft February 3, 2025 21:55
build_files/base/01-build-fix.sh Outdated Show resolved Hide resolved
build_files/base/03-install-kernel-akmods.sh Outdated Show resolved Hide resolved
build_files/base/07-base-image-changes.sh Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably want to use dnf5 config-manager setopt to turn these off instead of using sed.

build_files/shared/build-base.sh Show resolved Hide resolved
@inffy inffy marked this pull request as ready for review February 4, 2025 05:53
@GarciaLnk
Copy link
Contributor

We should not merge this until uupd is ready.

@inffy inffy marked this pull request as draft February 4, 2025 07:44
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 5, 2025
@inffy inffy marked this pull request as ready for review February 5, 2025 08:04
@inffy inffy enabled auto-merge February 5, 2025 08:04
@inffy inffy disabled auto-merge February 5, 2025 08:08
@inffy inffy added this pull request to the merge queue Feb 5, 2025
Merged via the queue into ublue-os:main with commit 6fcdce4 Feb 5, 2025
27 checks passed
@inffy inffy deleted the unwrap-dnf5 branch February 5, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants