Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common steps to the script files #1

Draft
wants to merge 10 commits into
base: ubicloud
Choose a base branch
from

Conversation

enescakir
Copy link
Member

Each packer template has duplicate Ubicloud steps that we can extract into common script files. I've created this pull request for initial feedback. If it seems acceptable to you, I'll rebase my previous commits.

@enescakir enescakir requested review from fdr, byucesoy and velioglu April 26, 2024 18:34
@enescakir enescakir self-assigned this Apr 26, 2024
@enescakir enescakir force-pushed the ubicloud branch 4 times, most recently from d9f7b90 to 80ca0d5 Compare May 9, 2024 07:10
@enescakir enescakir force-pushed the ubicloud branch 2 times, most recently from 0990436 to cab186f Compare May 14, 2024 06:48
@enescakir enescakir force-pushed the ubicloud branch 7 times, most recently from 911430a to 90f9a56 Compare May 23, 2024 14:18
@fdr
Copy link

fdr commented May 31, 2024

Huh, why is so much added lines? Are some of the lines actually un-doing stuff done previously?

Copy link

@fdr fdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Add nvidia-cuda-toolkit to the GPU image (#2)

Add nvidia-cuda-toolkit and cuda-drivers

cuda-12-4

add cudnn

add cudnn to env

just install cudnn
@enescakir enescakir force-pushed the ubicloud branch 6 times, most recently from f3199e4 to a07092f Compare August 5, 2024 17:18
@enescakir enescakir force-pushed the ubicloud branch 3 times, most recently from ec985f6 to 38cbfc6 Compare August 15, 2024 18:52
@enescakir enescakir force-pushed the ubicloud branch 4 times, most recently from c72a177 to 28b6e86 Compare August 27, 2024 12:48
@enescakir enescakir force-pushed the ubicloud branch 3 times, most recently from b2adcd2 to a597803 Compare October 7, 2024 12:51
@enescakir enescakir force-pushed the ubicloud branch 3 times, most recently from 8aef658 to c59a1c8 Compare October 10, 2024 14:34
@enescakir enescakir force-pushed the ubicloud branch 4 times, most recently from c2251a3 to 2a334b8 Compare November 28, 2024 16:18
@enescakir enescakir force-pushed the ubicloud branch 4 times, most recently from 8a283ae to 4d02a79 Compare January 9, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants