Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to leave off empty array braces. #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

chr15m
Copy link

@chr15m chr15m commented Jun 25, 2018

The combination of querystring_parser and Django will not correctly parse the params generated by this library unless you leave off the empty braces []. This patch adds an option to do so.

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@davidnemec
Copy link

Would love to see this merged. @chr15m any chance you can fix failing CI and maybe someone from Uber will look into this?

@chr15m chr15m force-pushed the master branch 2 times, most recently from 9d6830c to 63d6b02 Compare May 16, 2019 04:07
@chr15m
Copy link
Author

chr15m commented May 16, 2019

@davidnemec I have fixed the tests.

@tomasbedrich
Copy link

Good job @chr15m! I think there is also a need to sign Contributor License Agreement for CI to pass. Would you mind signing it please?

@chr15m
Copy link
Author

chr15m commented Jul 3, 2019

@tomasbedrich I will not sign this CLA. You're welcome to the code of course!

@tomasbedrich
Copy link

tomasbedrich commented Jul 4, 2019

May I ask you, what is the reason not to sign it? I am not working at Uber so my motivation is not to push you into something you don't like. It would be just great to see your code merged for me to use it in my project. Of course, I respect you right to decline the CLA but it would be a pitty if your work remains unmerged (or someone else would need to duplicate it) just because of CLA.

@chr15m
Copy link
Author

chr15m commented Jul 4, 2019

I do not have the time to determine the legal implications of signing the document.

It is possible to add git based dependencies to your requirements file and you could use this fork which includes the PRs: [email protected]:CultureCounts/multidimensional_urlencode.git.

Best of luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants