-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to leave off empty array braces. #12
base: master
Are you sure you want to change the base?
Conversation
|
Would love to see this merged. @chr15m any chance you can fix failing CI and maybe someone from Uber will look into this? |
9d6830c
to
63d6b02
Compare
@davidnemec I have fixed the tests. |
Good job @chr15m! I think there is also a need to sign Contributor License Agreement for CI to pass. Would you mind signing it please? |
@tomasbedrich I will not sign this CLA. You're welcome to the code of course! |
May I ask you, what is the reason not to sign it? I am not working at Uber so my motivation is not to push you into something you don't like. It would be just great to see your code merged for me to use it in my project. Of course, I respect you right to decline the CLA but it would be a pitty if your work remains unmerged (or someone else would need to duplicate it) just because of CLA. |
I do not have the time to determine the legal implications of signing the document. It is possible to add git based dependencies to your requirements file and you could use this fork which includes the PRs: Best of luck. |
The combination of querystring_parser and Django will not correctly parse the params generated by this library unless you leave off the empty braces
[]
. This patch adds an option to do so.