lifecycle.go documentation fix #1256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix function defined in documentation for `StartHook` and `StopHook` to match the reset of the example.
jkanywhere
commented
Jan 5, 2025
| @@ -86,7 +86,7 @@ func StartHook[T HookFunc](start T) Hook { | |||
| // StopHook returns a new Hook with stop as its [Hook.OnStop] function, | |||
| // wrapping its signature as needed. For example, given the following function: | |||
| // | |||
| // func myhook() { | |||
| // func myfunc() { | |||
There was a problem hiding this comment.
The name myfunc is used on lines 95, 101.
| @@ -53,7 +53,7 @@ type Hook struct { | |||
| // StartHook returns a new Hook with start as its [Hook.OnStart] function, | |||
| // wrapping its signature as needed. For example, given the following function: | |||
| // | |||
| // func myhook() { | |||
| // func myfunc() { | |||
There was a problem hiding this comment.
THe name myfunc is used on lines 62 and 68.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix function defined in documentation for
StartHookandStopHookto match the reset of the example.