https://github.com/uavorg/uavstack/issues/349

1、The tmax and tmin reset cycles are shortened to the default 1 hour #350 2、The initial time the mof gets tmax is empty, and NullPointerException is thrown
uavorg · Jul 24, 2018 · e18c656 · e18c656
1 parent 7f104bc
commit e18c656
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 11 deletions.
diff --git a/...framework/src/main/java/com/creditease/monitor/captureframework/spi/CaptureConstants.java b/...framework/src/main/java/com/creditease/monitor/captureframework/spi/CaptureConstants.java
@@ -25,8 +25,8 @@
  */
 public class CaptureConstants {
 
-    // 1 day ttl for tmax, tmin
-    public final static long MEI_INST_TTL = 24 * 3600 * 1000;
+    // 1 hour ttl for tmax, tmin
+    public final static long MEI_INST_TTL = 1 * 3600 * 1000;
 
     // default monitor id
     public final static String MONITOR_SERVER = "server";

diff --git a/...rframework/src/main/java/com/creditease/monitor/handlers/AbsServerRespTimeCapHandler.java b/...rframework/src/main/java/com/creditease/monitor/handlers/AbsServerRespTimeCapHandler.java
@@ -65,14 +65,14 @@ protected void recordCounters(CaptureContext context, MonitorElementInstance ins
             /**
              * NOTE: for no-http
              */
-            if (rtCode==-1) {
+            if (rtCode == -1) {
                 inst.increValue(CaptureConstants.MEI_ERROR);
-                respCode="Err";
+                respCode = "Err";
             }
-            else if (rtCode==1) {
-                respCode="OK";
+            else if (rtCode == 1) {
+                respCode = "OK";
             }
-            
+
             inst.increValue(CaptureConstants.MEI_RC + respCode);
         }
     }
@@ -103,14 +103,18 @@ protected void doCommonCounters(CaptureContext context, MonitorElementInstance i
                 MonitorElementInstance.CompareSetOperation.MAX);
 
         /**
-         * NOTE: tmax, tmin, 每24小时会自动RESET，避免一个巨大的tmax或一个很小的tmin
+         * NOTE: tmax, tmin, 每1小时会自动RESET，避免一个巨大的tmax或一个很小的tmin
          */
         if (isMax == true) {
 
             inst.setValue(CaptureConstants.MEI_RESP_MAXTIME_ST, end);
         }
         else {
-            long tmax_st = (Long) inst.getValue(CaptureConstants.MEI_RESP_MAXTIME_ST);
+            Object tmaxSt = inst.getValue(CaptureConstants.MEI_RESP_MAXTIME_ST);
+            if (tmaxSt == null) {
+                return;
+            }
+            long tmax_st = (Long) tmaxSt;
 
             if (end - tmax_st > CaptureConstants.MEI_INST_TTL) {
                 inst.setValue(CaptureConstants.MEI_RESP_MAXTIME, new AtomicLong(respTime));
@@ -126,9 +130,13 @@ protected void doCommonCounters(CaptureContext context, MonitorElementInstance i
             inst.setValue(CaptureConstants.MEI_RESP_MINTIME_ST, end);
         }
         else {
-            long tmax_st = (Long) inst.getValue(CaptureConstants.MEI_RESP_MINTIME_ST);
+            Object tminSt = inst.getValue(CaptureConstants.MEI_RESP_MINTIME_ST);
+            if (tminSt == null) {
+                return;
+            }
+            long tmin_st = (Long) tminSt;
 
-            if (end - tmax_st > CaptureConstants.MEI_INST_TTL) {
+            if (end - tmin_st > CaptureConstants.MEI_INST_TTL) {
                 inst.setValue(CaptureConstants.MEI_RESP_MINTIME, new AtomicLong(respTime));
                 inst.setValue(CaptureConstants.MEI_RESP_MINTIME_ST, end);
             }