Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Field dictionaries (PDF 1.7 Section 12.7.3) #22

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Feature: Field dictionaries (PDF 1.7 Section 12.7.3) #22

merged 6 commits into from
Oct 20, 2023

Conversation

tingerrr
Copy link
Contributor

This PR adds the writers and types for writing form field dictionaries. The specific types of form field dictionaries have been left for another PR. This PR also fixes some dead links in the documentation introduced by #21.

@tingerrr tingerrr mentioned this pull request Oct 19, 2023
Open
18 tasks
reknih
reknih reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@reknih reknih left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Will 12.7.3.3 (needed for PDF 2 compatibility) submitted in a different PR too?

src/forms.rs Outdated Show resolved Hide resolved
@tingerrr
Copy link
Contributor Author

tingerrr commented Oct 20, 2023 •
edited
Loading

Nice. Will 12.7.3.3 (needed for PDF 2 compatibility) submitted in a different PR too?

Yes, that will be part of Text and Choice fields coming shortly after this is merged. It all fits neatly into one PR, whereas Buttons and Signatures likely need one each. This way, I should be able to work on each PR separately, while I wait for review on the others.

@reknih reknih merged commit ab188ac into typst:main Oct 20, 2023
1 check passed
@tingerrr tingerrr mentioned this pull request Oct 26, 2023
Merged
@tingerrr tingerrr deleted the field-dictionaries branch November 25, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reknih reknih reknih left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tingerrr @reknih