Skip to content

Commit

Permalink
Correct off-by-one error in flags
Browse files Browse the repository at this point in the history
  • Loading branch information
tingerrr committed Nov 3, 2023
1 parent 596868e commit 1655bce
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 29 deletions.
22 changes: 11 additions & 11 deletions src/actions.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -176,46 +176,46 @@ bitflags::bitflags! {
const INCLUDE_NO_VALUE_FIELDS = 2;
/// Export the fields as HTML instead of submitting as FDF. Ignored if
/// `SUBMIT_PDF` or `XFDF` are set.
const EXPORT_FORMAT = 1 << 3;
const EXPORT_FORMAT = 1 << 2;
/// Field name should be submitted using an HTTP GET request, otherwise
/// POST. Should only be if `EXPORT_FORMAT` is also set.
const GET_METHOD = 1 << 4;
const GET_METHOD = 1 << 3;
/// Include the coordinates of the mouse when submit was pressed. Should
/// only be if `EXPORT_FORMAT` is also set.
const SUBMIT_COORDINATES = 1 << 5;
const SUBMIT_COORDINATES = 1 << 4;
/// Submit field names and values as XFDF instead of submitting an FDF.
/// Should not be set if `SUBMIT_PDF` is set. PDF1.4+.
const XFDF = 1 << 6;
const XFDF = 1 << 5;
/// Include all updates done to the PDF document in the submission FDF
/// file. Should only be used when `XFDF` and `EXPORT_FORMAT` are not
/// set. PDF 1.4+.
const INCLUDE_APPEND_SAVES = 1 << 7;
const INCLUDE_APPEND_SAVES = 1 << 6;
/// Include all markup annotations of the PDF dcoument in the submission
/// FDF file. Should only be used when `XFDF` and `EXPORT_FORMAT` are
/// not set. PDF 1.4+.
const INCLUDE_ANNOTATIONS = 1 << 8;
const INCLUDE_ANNOTATIONS = 1 << 7;
/// Submit the PDF file instead of an FDF file. All other flags other
/// than `GET_METHOD` are ignored if this is set. PDF 1.4+.
const SUBMIT_PDF = 1 << 9;
const SUBMIT_PDF = 1 << 8;
/// Convert fields which represent dates into the
/// [canonical date format](crate::types::Date). The interpretation of
/// a form field as a date is is not specified in the field but the
/// JavaScript code that processes it. PDF 1.4+.
const CANONICAL_FORMAT = 1 << 10;
const CANONICAL_FORMAT = 1 << 9;
/// Include only the markup annotations made by the current user (the
/// `/T` entry of the annotation) as determined by the remote server
/// the form will be submitted to. Should only be used when `XFDF` and
/// `EXPORT_FORMAT` are not set and `INCLUDE_ANNOTATIONS` is set. PDF
/// 1.4+.
const EXCLUDE_NON_USER_ANNOTS = 1 << 11;
const EXCLUDE_NON_USER_ANNOTS = 1 << 10;
/// Include the F entry in the FDF file.
/// Should only be used when `XFDF` and `EXPORT_FORMAT` are not set.
/// PDF 1.4+
const EXCLUDE_F_KEY = 1 << 12;
const EXCLUDE_F_KEY = 1 << 11;
/// Include the PDF file as a stream in the FDF file that will be submitted.
/// Should only be used when `XFDF` and `EXPORT_FORMAT` are not set.
/// PDF 1.5+.
const EMBED_FORM = 1 << 14;
const EMBED_FORM = 1 << 13;
}
}

Expand Down
36 changes: 18 additions & 18 deletions src/forms.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ bitflags::bitflags! {
/// as opposed to an incremental update. Merely updating the file by
/// appending new information to the end of the previous version is
/// safe.
const APPEND_ONLY = 1 << 2;
const APPEND_ONLY = 2;
}
}

Expand Down Expand Up @@ -480,73 +480,73 @@ bitflags::bitflags! {
const REQUIRED = 2;
/// The field shall not be exported by a
/// [submit-form](crate::types::ActionType::SubmitForm)[`Action`].
const NO_EXPORT = 1 << 3;
const NO_EXPORT = 1 << 2;
/// The entered text shall not be spell-checked, can be used for text
/// and choice fields.
const DO_NOT_SPELL_CHECK = 1 << 23;
const DO_NOT_SPELL_CHECK = 1 << 22;

// Button specific flags

/// Exactly one radio button shall be selected at all times; selecting
/// the currently selected button has no effect. If unset, clicking
/// the selected button deselects it, leaving no button selected. Only
/// permissible for radio buttons.
const NO_TOGGLE_TO_OFF = 1 << 15;
const NO_TOGGLE_TO_OFF = 1 << 14;
/// The field is a set of radio buttons; if clear, the field is a check
/// box. This flag may be set only if the `PUSHBUTTON` flag is unset.
const RADIO = 1 << 16;
const RADIO = 1 << 15;
/// The field is a push button that does not retain a permanent
/// value.
const PUSHBUTTON = 1 << 17;
const PUSHBUTTON = 1 << 16;
/// A group of radio buttons within a radio button field that use the
/// same value for the on state will turn on and off in unison; that
/// is if one is checked, they are all checked. If unset, the buttons
/// are mutually exclusive (the same behavior as HTML radio buttons).
/// PDF 1.5+.
const RADIOS_IN_UNISON = 1 << 26;
const RADIOS_IN_UNISON = 1 << 25;

// Text field specific flags

/// The text may contain multiple lines of text, otherwise the text is
/// restricted to one line.
const MULTILINE = 1 << 13;
const MULTILINE = 1 << 12;
/// The text contains a password and should not be echoed visibly to
/// the screen.
const PASSWORD = 1 << 14;
const PASSWORD = 1 << 13;
/// The entered text represents a path to a file who's contents shall be
/// submitted as the value of the field. PDF 1.4+.
const FILE_SELECT = 1 << 21;
const FILE_SELECT = 1 << 20;
/// The field shall not scroll horizontally (for single-line) or
/// vertically (for multi-line) to accomodate more text. Once the field
/// is full, no further text shall be accepted for interactive form
/// filling; for non-interactive form filling, the filler should take
/// care not to add more character than will visibly fit in the defined
/// area. PDF 1.4+.
const DO_NOT_SCROLL = 1 << 24;
const DO_NOT_SCROLL = 1 << 23;
/// The field shall eb automatically divided into as many equally
/// spaced postions or _combs_ as the value of [`Field::max_len`]
/// and the text is layed out into these combs. May only be set if
/// the [`Field::max_len`] property is set and if the [`MULTILINE`],
/// [`PASSWORD`] and [`FILE_SELECT`] flags are clear. PDF 1.5+.
const COMB = 1 << 25;
const COMB = 1 << 24;
/// The value of this field shall be a rich text string. If the field
/// has a value, the [`TextField::rich_text_value`] shall specify the
/// rich text string. PDF 1.5+.
const RICH_TEXT = 1 << 26;
const RICH_TEXT = 1 << 25;

// Choice field specific flags

/// The field is a combo box if set, else it's a list box.
const COMBO = 1 << 18;
const COMBO = 1 << 17;
/// The combo box shall include an editable text box as well as a
/// drop-down list. Shall only be used if [`COMBO`] is set.
const EDIT = 1 << 19;
const EDIT = 1 << 18;
/// The field’s option items shall be sorted alphabetically. This
/// flag is intended for use by writers, not by readers.
const SORT = 1 << 20;
const SORT = 1 << 19;
/// More than one option of the choice field may be selected
/// simultaneously. PDF 1.4+.
const MULTI_SELECT = 1 << 22;
const MULTI_SELECT = 1 << 21;
/// The new value shall be committed as soon as a selection is made
/// (commonly with the mouse). In this case, supplying a value for
/// a field involves three actions: selecting the field for fill-in,
Expand All @@ -556,6 +556,6 @@ bitflags::bitflags! {
///
/// If set, processing does not wait for leaving the field action to
/// occur, but immediately proceeds to the third step. PDF 1.5+.
const COMMIT_ON_SEL_CHANGE = 1 << 27;
const COMMIT_ON_SEL_CHANGE = 1 << 28;
}
}

0 comments on commit 1655bce

Please sign in to comment.