Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update output types and add some missing outputs #31

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

Vampire
Copy link
Collaborator

@Vampire Vampire commented Aug 26, 2024

Fixes #30

Copy link
Collaborator Author

Vampire commented Aug 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator Author

Vampire commented Aug 26, 2024

I've had a look through the outputs and did my best to correct the types and add some missing ones in the versions present in the catalog.

But I suggest you also look through them and verify, and not just skim over my changes here, to have more confidence by 4-eyes-principle.

@krzema12 krzema12 changed the title Update output types and add some missig outputs Update output types and add some missing outputs Jan 27, 2025
@Vampire Vampire force-pushed the vampire/issue-30 branch 2 times, most recently from 833fa39 to 96a9d1d Compare January 27, 2025 10:39
Copy link
Member

@krzema12 krzema12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sharp, thank you! 🙇

@krzema12 krzema12 merged commit 6fc06d3 into main Jan 27, 2025
4 of 5 checks passed
@krzema12 krzema12 deleted the vampire/issue-30 branch January 27, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review current output types
2 participants